Greptile Summary

This PR removes RPyC entirely and replaces it with the project's own LCM-based pub/sub RPC layer (LCMRPC). The per-worker RPyC servers, the rpyc_port registry field, and the associated retry/connect logic are all deleted; a new CoordinatorRPC class exposes the ModuleCoordinator's control surface as named @rpc methods over LCM, and RemoteModuleSource uses that endpoint to list modules and build proxies.

• CoordinatorRPC handles serve/connect lifecycle; _ensure_no_existing_service prevents double-serving on the same LCM bus.
• RemoteModuleSource now builds either a full RPCClient (when the module class is importable) or a names-only _RemoteProxy, sharing a single LCMRPC connection with the coordinator.
• Blueprint gains __getstate__/__setstate__ so its MappingProxyType fields survive the pickle round-trip required by LCMRPC; RunEntry.load drops unknown keys for forward-compatibility with older registry files.

Confidence Score: 5/5

The RPyC removal is clean and well-scoped; the LCM-based replacement follows existing pub/sub patterns and all previously-flagged gaps have been noted in prior threads.

The change is a straightforward excision of one RPC transport and substitution of another already used by the rest of the codebase. New code paths are covered by updated tests, the Blueprint pickle fix is correct and tested, and RunEntry forward-compatibility is handled. The only new findings are cosmetic: a factory method that is defined but never called, and a magic string constant that could use a comment.

No files require special attention beyond what was already flagged in previous review rounds.

Important Files Changed

Sequence Diagram

sequenceDiagram
    participant CLI as dimos CLI / Dimos.connect()
    participant RMS as RemoteModuleSource
    participant CRPC as CoordinatorRPC
    participant LCM as LCM Bus
    participant MC as ModuleCoordinator
    participant Proxy as RPCClient / _RemoteProxy

    CLI->>RMS: "RemoteModuleSource(timeout=5)"
    RMS->>CRPC: CoordinatorRPC.connect(timeout)
    CRPC->>LCM: call_sync(Coordinator/ping)
    LCM->>MC: ping()
    MC-->>LCM: pong
    LCM-->>CRPC: pong
    CRPC-->>RMS: CoordinatorRPC instance

    CLI->>RMS: list_module_names()
    RMS->>CRPC: call(list_modules)
    CRPC->>LCM: call_sync(Coordinator/list_modules)
    LCM->>MC: list_modules()
    MC-->>LCM: [ModuleDescriptor, ...]
    LCM-->>RMS: descriptors

    CLI->>RMS: get_module(StressTestModule)
    RMS->>RMS: importlib.import_module(qualified_path)
    alt import succeeds
        RMS->>Proxy: "RPCClient(None, cls, rpc=coord.rpc)"
    else import fails
        RMS->>Proxy: _RemoteProxy(coord.rpc, name, rpc_names)
    end
    Proxy-->>CLI: proxy

    CLI->>Proxy: proxy.ping()
    Proxy->>LCM: call_sync(StressTestModule/ping)
    LCM->>MC: ping() on module
    MC-->>LCM: pong
    LCM-->>CLI: pong

_{Reviews (4): Last reviewed commit: "Merge branch 'main' into paul/feat/remov..." | Re-trigger Greptile}

Codecov Report

❌ Patch coverage is 84.98294% with 44 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!